Open source filter and uiElements.R #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for splitkbcompare ready! 🔨 Explore the source changes: 5a1b5ce 🔍 Inspect the deploy log: https://app.netlify.com/sites/splitkbcompare/deploys/61cc9fcd28a1da00070d04ac 😎 Browse the preview: https://deploy-preview-80--splitkbcompare.netlify.app |
|
All looks good to me! I think modularizing the UI components is a step in the right direction - it will certainly make things easier when working with other UIs like shinydashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Some small changes and one optional larger change.
Small changes:
includeHTMLfor footer &includeCSSfor .cssLarger change
Whilst trying out
shinydashboardI was scrolling though the file a lot. All the filter buttons made it somewhat difficult to get an overview of the structure and all the nested functions. Moving all the filter buttons to a separate file makes it a bit easier to oversee what happens where inui.R.Let me know what you think about the changes!