Make sure standard_error is initialized in web_extensions_session_init(). #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng servers. This is intended to provide a way for a confined web browser to start native code helpers for their extensions. At present it can start the servers installed on the host system. But in future this could be extended to cover sandboxed native messaging servers too.
Currently all clients pass this check, but the intent is to add an appropriate check to refuse access to Flatpak and Snap apps that are not web browsers.
…n the wrong state. This could occur if the session is closed between when the task is scheduled and when it is run.
This ensures the session won't be freed while the callback is running, as could happen when close_sessions_in_thread_func() runs. While this creates a reference cycle, it will be broken when the session is closed.
jhenstridge
force-pushed
the
native-messaging-portal
branch
2 times, most recently
from
fd77dae
to
f04f206
Compare
jhenstridge
force-pushed
the
native-messaging-portal
branch
3 times, most recently
from
5756ca8
to
633348f
Compare
jhenstridge
force-pushed
the
native-messaging-portal
branch
6 times, most recently
from
143482c
to
c13f2e5
Compare
jhenstridge
force-pushed
the
native-messaging-portal
branch
from
0897045
to
412f054
Compare
jhenstridge
force-pushed
the
native-messaging-portal
branch
2 times, most recently
from
3f112c7
to
d287862
Compare
jhenstridge
force-pushed
the
native-messaging-portal
branch
from
7a3bb13
to
4f25231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.