-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent unbinding of errorHandler.report #41
Conversation
That false sense of security clumsy tests give you... |
fafd680
to
ff06e0f
Compare
Would you mind squashing this down? |
Nope, that's a merge and I've got no idea how to squash it. Found some info here, but both solutions are very hacky and destructive. If you know how to do it, I add you to my fork so that you do it yourself. |
The following should fix ya up: |
The more you know... It's done. |
@@ -27,6 +27,7 @@ | |||
"ember-cli-app-version": "^1.0.0", | |||
"ember-cli-content-security-policy": "0.4.0", | |||
"ember-cli-dependency-checker": "^1.1.0", | |||
"ember-cli-es5-shim": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this merely defensive? I'm not too worried about old ass browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for PhantomJS. This polyfill is in devDependencies
and will not make it into app builds.
OK, so I get what's happening here, but I'm not really sure how this bug can happen. Can you give me an example scenario? |
Wut? Just throw any error, and |
Prevent unbinding of errorHandler.report
Will you release this? |
Already released! 0.2.4 is out, and 1.0 is hot on its tail (same as 0.2.4, just with the 1.0 name to indicate that I believe it's production ready). |
You rock! 🗿 |
fixes #40