Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report test coverage using nyc #16

Closed
wants to merge 1 commit into from
Closed

Conversation

dhui
Copy link
Contributor

@dhui dhui commented Dec 2, 2018

@dhui dhui mentioned this pull request Dec 2, 2018
@dhui
Copy link
Contributor Author

dhui commented Dec 2, 2018

Looks like the build for node 4 is failing. Do we need to continue supporting node 4?

@jhermsmeier
Copy link
Owner

Fist of all, thank you for the work you've put in!
With the fairly minimal size of this module I have a hard time seeing the benefits of reporting test coverage though. Further, this breaks the Node v4 build due to nyc's incompatibility.
While there's no real reason to keep supporting Node v4, it'd have to be a major version bump to discontinue support for it, and there's also no reason to drop Node v4 support either.
So I'll close this for now, possibly to be revisited at a later time.
If you have some strong arguments in its favour, I'd love to hear them though.

@jhermsmeier jhermsmeier closed this Dec 3, 2018
@dhui
Copy link
Contributor Author

dhui commented Dec 3, 2018

Test coverage stats may have been useful in catching the broken has() implementation.

@dhui dhui mentioned this pull request Dec 3, 2018
@dhui
Copy link
Contributor Author

dhui commented Dec 6, 2018

I've downgraded to a version of nyc that supports node v4: https://travis-ci.org/dhui/node-http-link-header/builds/464138253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants