-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperlink to tab #34
Comments
HI @markbattistella. Should be easy enough to add, but I have some concerns about treating tabs as anchor links. Auto-scrolling a tab set to the top of the viewport means site visitors will arrive on a page without context for the tab content they are viewing. Is the goal to allow navigating to directly to tab sets from other sites or to jump directly to tab sets from links in your own site docs? |
I think it may have been a bug when I was doing it locally but on the live environment it works. But the intention was that you would have the user be pointed into the tab, and then the heading without having to click in |
@markbattistella Well, glad it's fixed! :) Thanks for taking the time to file the PR. Much appreciated. |
Hi @jhildenbiddle , thank you for developing and maintaining
I think there should be a conditional statement of routerMode in |
Hi @A-Circle-Zhang -- I've made the necessary change on the dev branch. Everything seems to work on my end with Thanks! |
Maybe I've missed it somewhere, but it would be cool to be able to link to a tab section and to an active tab.
Having a link to http://localhost:3000/#/newPage?id=windows
And it jumping to the
newPage
document, and activating thewindows
tabThe text was updated successfully, but these errors were encountered: