Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go test fails from master #137

Closed
tegk opened this issue Oct 31, 2019 · 4 comments
Closed

go test fails from master #137

tegk opened this issue Oct 31, 2019 · 4 comments

Comments

@tegk
Copy link

tegk commented Oct 31, 2019

What I did:
run go test

What I expected:
tests are passing

What I got:
--- FAIL: TestReadHeader (0.00s)
header_test.go:516: Stripped SID value
got : "",
want: "0",
input: "SID : 0\r\n"
header_test.go:516: Stripped Audio Mode value
got : "",
want: "None",
input: "Audio Mode : None\r\n"
header_test.go:516: Stripped Privilege value
got : "",
want: "127",
input: "Privilege : 127\r\n"
FAIL
exit status 1
FAIL github.com/jhillyerd/enmime 0.042s

Release or branch I am using:
master
@requaos
Copy link
Collaborator

requaos commented Nov 1, 2019

This is a known issue relating to a bug fix for the textproto package that was introduced in go v1.13.1 and backported to v1.12.10

We have a fix for this in the develop branch
See merged pull request for details

@requaos requaos closed this as completed Nov 1, 2019
@tegk
Copy link
Author

tegk commented Nov 1, 2019

would you consider a hot-fix or what is your ETA? I am hesitant to use a library where the tests are not working.

@jhillyerd
Copy link
Owner

jhillyerd commented Nov 2, 2019 via email

jhillyerd added a commit that referenced this issue Nov 24, 2019
@jhillyerd
Merge tag 'v0.7.0' into develop
cf488a7 
Added
- Public DecodeHeaders function for getting header data without processing the
  body parts (thanks requaos.)
- Test coverage over 90% (thanks requaos!)

Changed
- Update dependencies

Fixed
- Do not attempt to detect character set for short messages (#131, thanks
  requaos.)
- Possible slice out of bounds error (#134, thanks requaos.)
- Tests on Go 1.13 no longer fail due to textproto change (#137, thanks to
  requaos.)
@jhillyerd
Copy link
Owner

New release has been cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhillyerd @requaos @tegk