Add handling for blank lines in continued header fields #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PRs, you are on a roll. 🎱 My home internet has been offline a couple days, I'll try and dig into these once I get back online. |
jhillyerd
requested changes
Dec 15, 2016
| @@ -72,52 +72,57 @@ func debug(format string, args ...interface{}) { | |||
| // readHeader reads a block of SMTP or MIME headers and returns a textproto.MIMEHeader. | |||
| // Header parse warnings & errors will be added to p.Errors, io errors will be returned directly. | |||
| func readHeader(r *bufio.Reader, p *Part) (textproto.MIMEHeader, error) { | |||
| // if true { | |||
| // return textproto.NewReader(r).ReadMIMEHeader() | |||
| // } | |||
| data[i] = 'x' | ||
| } | ||
| sdata := string(data) | ||
| _ = sdata |
There was a problem hiding this comment.
I think the _ assignment can be removed, sdata is referenced below
| "SID : 0\r\n" + | ||
| "Audio Mode : None\r\n" + | ||
| "Privilege : 127\r\n\r\n" | ||
| */ |
There was a problem hiding this comment.
This looks like it was a temporary comment, can it be removed?
|
Let me know if you'd rather I make the changes myself - I'm not sure how much time you want to put into it. But I fear if I make the changes and squash the commit, you will not get credit in the commit log. |
|
Manually merged w/ fixups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current handling of continued header fields would terminate if the field had a blank line, ie
The root part would end up containing:
Added handling for this and some expanded tests.