mime: invalid media parameter #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst character of the media parameter value
Requaos/unquoted boundary
|
Each of the two above commits, solve a different problem. Both problems result in the same error.
|
|
Thanks. BTW, I think your test coverage increase may have drawn some recent attention: https://starcharts.herokuapp.com/jhillyerd/enmime |
jhillyerd
added a commit
that referenced
this pull request
Feb 23, 2020
Added - Inject a `application/octet-stream` as default content type when none is present (#140, thanks requaos) - Add support for content-type params to part & encoding (#148, thanks pzeinlinger) - UTF-7 support (#17) Fixed - Handle missing parameter values in the middle of the media parameter list (#139, thanks requaos) - Fix boundaryReader to respect length instead of capacity (#145, thanks dcormier) - Handle very empty mime parts (#144, thanks dcormier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we handle media parameters with missing values if they are the last parameter, this fix allows for the handling of media parameters missing value in the middle of the parameter list.