Improve performance of boundaryReader #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcormier
changed the title
Explicitly read/write a single byte rather than using `io.CopyN` to copy a single byte. Before the change: ``` BenchmarkBoundaryReader-12 544516 1909 ns/op 6704 B/op 15 allocs/op ``` After: ``` BenchmarkBoundaryReader-12 1039579 1067 ns/op 4495 B/op 7 allocs/op ``` From 15 allocs/op down to 7. Fixes jhillyerd#169.
|
Excellent, thank you |
|
Any interest in tagging a release for that, @jhillyerd? I think it'd be nice to get that out there. |
|
Going to hold off for a bit because of the recent post to #140. I suspect we are going to need to roll the continuation parsing code back to a state where it just follows the RFCs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly read/write a single byte rather than using
io.CopyNto copy a single byte.Before the change:
After:
From 15 allocs/op down to 7.
Fixes #169.