Remove whitespace between parameter=value and ; in headers #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhillyerd
reviewed
Jun 8, 2021
header.go
Outdated
| @@ -308,6 +308,10 @@ func fixMangledMediaType(mtype string, sep rune) string { | |||
| // Only terminate with semicolon if not the last parameter and if it doesn't already have a | |||
| // semicolon. | |||
| if i != len(parts)-1 && !strings.HasSuffix(mtype, ";") { | |||
| // Remove whitespace between parameter=value and ; | |||
| for strings.HasSuffix(mtype, " ") || strings.HasSuffix(mtype, "\t") { | |||
There was a problem hiding this comment.
https://staticcheck.io/docs/checks#S1017 suggests we replace this check and slice with two calls to strings.TrimSuffix
I also wonder if it would be better to use TrimRight, as your implementation will only remove a single trailing whitespace character.
There was a problem hiding this comment.
I think TrimRight is a better approach. It removes everything in the cutset. No need for 2 TrimSuffix calls.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the problem of PR: 193
Sorry for taking over, but I really need the fix :(
Let me know if there is anything you would like me to change.
Thanks for the package.