Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and test for text only bodies that are plain text #24

Merged
merged 1 commit into from
Feb 12, 2017
Merged

Fix and test for text only bodies that are plain text #24

merged 1 commit into from
Feb 12, 2017

Conversation

chris-garrett
Copy link
Contributor

@chris-garrett chris-garrett commented Feb 10, 2017 •
edited
Loading

No description provided.

@chris-garrett chris-garrett changed the title Fix and test for text only bodies that are plain text encoded Fix and test for text only bodies that are plain text Feb 10, 2017
@coveralls
Copy link

coveralls commented Feb 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 84.881% when pulling 4f05aff on chris-garrett:cg/plain-text-body-non-binary into 9f8c4e2 on jhillyerd:master.

@jhillyerd jhillyerd merged commit 4f05aff into jhillyerd:master Feb 12, 2017
@jhillyerd
Copy link
Owner

Thank you! I realized after looking at the code that you were basically working around a bug in the isBinaryBody method, so I fixed the bug and made a couple tweaks to your test in 8c6ab12. You also helped me discover #25 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris-garrett @coveralls @jhillyerd