-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder: Support other parts #244
Conversation
I actually removed testify from the codebase back in 2016, would rather not re-introduce it, not a fan. 8f740ea |
I like testify since it saves a lot typing. :) |
It was a while ago, so I forget the exact reasons, but my primary problem was that it's test output was not parseable when running the tests from vim, the colors looked like crap (line noise) and jumping to the point of failure didn't work. I also didn't like importing unnecessary things that could cause conflicts as a library to be used by others, I think go mod is smart enough to not force test dependencies on our users so probably less of a problem nowdays. |
@jhillyerd do you think I should remove testify? |
I tried this morning, testify no longer breaks go-vim, and doesn't seem any worse than any other failed tests with multi-line output. If I read https://go.dev/ref/mod#graph-pruning correctly, our choices will still impact the modules that import us until everyone is on Go 1.18. With that in mind, let's keep testify, but switch from 1.7.1 (very new, and not properly released on github), to 1.7.0 which has been around for more than a year. That way folks that import us have more control over when they move to 1.7.1. |
Closes #223
I moved other parts in multipart/related as inlines because I saw this image
Tested on eml message, looks fine