Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unencoded equals in quoted printable sanitizer #26

Merged
merged 2 commits into from
Feb 19, 2017

Conversation

chris-garrett
Copy link
Contributor

I ran into an issue today with the sanitizer. Another email from slack came through but this time it contained a url with query parameters. The '=' passes through to qp reader and fails. Here is my first pass. Thoughts?

@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage decreased (-0.01%) to 85.278% when pulling 29b4a40 on chris-garrett:develop into e6b7c6f on jhillyerd:develop.

@jhillyerd
Copy link
Owner

jhillyerd commented Feb 17, 2017

My first thought is "man Slack kinda sucks!" ;) I like your approach here though, nice! Could you add some tests to exercise the three red error paths in:

https://coveralls.io/builds/10212874/source?filename=quotedprint.go

Should be as easy as adding a few more cases to this test table:

https://github.com/jhillyerd/enmime/blob/master/quotedprint_test.go#L21

@chris-garrett
Copy link
Contributor Author

Yes, definitely.

@coveralls
Copy link

coveralls commented Feb 19, 2017

Coverage Status

Coverage increased (+0.5%) to 85.82% when pulling 3bd5d13 on chris-garrett:develop into e6b7c6f on jhillyerd:develop.

@jhillyerd jhillyerd merged commit b6ea523 into jhillyerd:develop Feb 19, 2017
@jhillyerd
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants