Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use CharsetReader when Part is attachement #43

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Don't use CharsetReader when Part is attachement #43

merged 1 commit into from
Dec 13, 2017

Conversation

XiaoMouR
Copy link
Contributor

For this issue

@coveralls
Copy link

coveralls commented Nov 22, 2017

Coverage Status

Coverage remained the same at 85.82% when pulling 6dac6f5 on leibiao:patch-1 into b6ea523 on jhillyerd:master.

@jhillyerd
Copy link
Owner

This is a really nice find. Thank you! I was really dreading digging into bug #34 but I have a feeling it has the same root cause as #42 you filed.

I've been very busy at work and it looks like I've let a back log of PRs pile up, will try and spend some time this weekend getting them merged.

Would it be possible for you to add a corresponding test to part_test.go? You could create a new testdata/parts file based on https://github.com/leibiao/enmime/blob/master/testdata/parts/multibase64.raw . Please try to limit the size of the test base64, I don't want to bloat the repository unnecessarily.

@jhillyerd jhillyerd mentioned this pull request Nov 22, 2017
jhillyerd added a commit that referenced this pull request Nov 27, 2017
@jhillyerd jhillyerd merged commit 6dac6f5 into jhillyerd:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants