Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for presence of $path/functions/__git.init.fish before sourcing it #103

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

hexclover
Copy link
Contributor

Closes #102.

Test 1: On a home-manager enabled NixOS with fish as default shell, the gst abbreviation works, and SSH with jump host works.
Test 2: On an Arch system with fish as default shell and OMF, the gst abbreviation works.

@hexclover hexclover marked this pull request as draft November 6, 2023 05:21
@hexclover hexclover force-pushed the master branch 2 times, most recently from 062f557 to 265dc22 Compare November 6, 2023 05:32
@hexclover hexclover marked this pull request as ready for review November 6, 2023 05:37
Copy link
Owner

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment or two explaining the why & how of this, it's going to be non-obvious to anyone that isn't familiar with how home-manager works, and I'm unlikely to remember either.

@PaulGrandperrin
Copy link

I tried this PR:

        {
          name = "plugin-git"; # git abbrs
          #src = plugin-git.src;
          src = pkgs.fetchFromGitHub {
            owner = "hexclover";
            repo = "plugin-git";
            rev = "master";
            sha256 = "sha256-efKPbsXxjHm1wVWPJCV8teG4DgZN5dshEzX8PWuhKo4";
          };
        }

and it fixes scp for me! thanks :)

@PaulGrandperrin
Copy link

I'm using NixOS + HM on unstable FWIW

@jhillyerd jhillyerd merged commit c2b38f5 into jhillyerd:master Nov 7, 2023
@jhillyerd
Copy link
Owner

Thanks!

@GaetanLepage
Copy link

Thanks for the fix !
Can you make a git release that would then ship this fix please ?
The plugin-git version in nixpkgs is still v0.1 (Feb. 2023)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with non-interactive shell where $path is not defined
4 participants