Skip to content

Latest commit

 

History

History
286 lines (186 loc) · 13.3 KB

CONTRIBUTING.md

File metadata and controls

286 lines (186 loc) · 13.3 KB
Raw

Contributing to Ionic for JHipster

Are you ready to contribute to Ionic for JHipster? We'd love to have you on board, and we will help you as much as we can. Here are the guidelines we'd like you to follow so that we can be of more help:

Questions and help

This is the Ionic for JHipster bug tracker, and it is used for Issues and Bugs and for Feature Requests.

If you have a question on using Ionic for JHipster, or if you need help with your JHipster project, please read JHipster's help page and use the JHipster and Ionic tags on StackOverflow or join our Gitter.im chat room.

Issues and Bugs

If you find a bug in the source code or a mistake in the documentation, you can help us by submitting a ticket to our GitHub issues. Even better, you can submit a pull request to the Ionic for JHipster generator project.

Please see the Submission Guidelines below.

Feature Requests

You can request a new feature by submitting a ticket to our GitHub issues. If you would like to implement a new feature then consider what kind of change it is:

  • Major Changes that you wish to contribute to the project should be discussed first. Please open a ticket which clearly states that it is a feature request in the title and explain clearly what you want to achieve in the description, and the JHipster team will discuss with you what should be done in that ticket. You can then start working on a Pull Request.
  • Small Changes can be proposed without any discussion. Open up a ticket which clearly states that it is a feature request in the title. Explain your change in the description, and you can propose a Pull Request straight away.

Submission Guidelines

Submitting an Issue

Before you submit your issue search the archive, maybe your question was already answered.

If your issue appears to be a bug, and has not been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. Providing the following information will increase the chances of your issue being dealt with quickly:

  • Overview of the issue - if an error is being thrown a stack trace helps
  • Motivation for or Use Case - explain why this is a bug for you
  • Reproduce the error - an unambiguous set of steps to reproduce the error. If you have a JavaScript error, maybe you can provide a live example with JSFiddle?
  • Related issues - has a similar issue been reported before?
  • Suggest a Fix - if you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit)
  • JHipster Version(s) - is it a regression?
  • JHipster configuration, a .yo-rc.json file generated in the root folder - this will help us to replicate the scenario, you can remove the rememberMe key.
  • Entity configuration(s) entityName.json files generated in the .jhipster directory - if the error is during an entity creation or associated with a specific entity
  • Browsers and Operating System - is this a problem with all browsers or only IE8?

You can use jhipster info to provide us the information we need.

Click here to open a bug issue with a pre-filled template. For feature requests and enquiries you can use this template.

You can run jhipster info in your project folder to get most of the above required info.

Issues opened without any of these info will be closed without any explanation.

Submitting a Pull Request

Before you submit your pull request consider the following guidelines:

  • Search GitHub for an open or closed Pull Request that relates to your submission.

  • If you want to modify the JHipster generator, read our Generator development setup

  • Make your changes in a new git branch

    git checkout -b my-fix-branch main

  • Create your patch, including appropriate test cases.

  • Follow our Coding Rules.

  • Generate a new Ionic for JHipster project, and ensure that all tests pass

    yo jhipster-ionic <name>
cd name && ionic test

  • Test that the new project runs correctly:

    ionic serve

  • Commit your changes using a descriptive commit message that follows our commit message conventions.

    git commit -a

    Note: the optional commit -a command line option will automatically "add" and "rm" edited files.

  • Push your branch to GitHub:

    git push origin my-fix-branch

  • In GitHub, send a pull request to jhipster/generator-jhipster-ionic:main.

  • If we suggest changes then

    • Make the required updates.

    • Re-run the JHipster tests on your sample generated project to ensure tests are still passing.

    • Rebase your branch and force push to your GitHub repository (this will update your Pull Request):

      git rebase main -i
git push -f

That's it! Thank you for your contribution!

Resolving merge conflicts ("This branch has conflicts that must be resolved")

Sometimes your PR will have merge conflicts with the upstream repository's main branch. There are several ways to solve this but if not done correctly this can end up as a true nightmare. So here is one method that works quite well.

  • First, fetch the latest information from the main

    git fetch upstream

  • Rebase your branch against the upstream/main

    git rebase upstream/main

  • Git will stop rebasing at the first merge conflict and indicate which file is in conflict. Edit the file, resolve the conflict then

    git add <the file that was in conflict>
git rebase --continue

  • The rebase will continue up to the next conflict. Repeat the previous step until all files are merged and the rebase ends successfully.

  • Re-run the JHipster tests on your sample generated project to ensure tests are still passing.

  • Force push to your GitHub repository (this will update your Pull Request)

    git push -f

After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository:

  • Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:

    git push origin --delete my-fix-branch

  • Check out the main branch:

    git checkout main -f

  • Delete the local branch:

    git branch -D my-fix-branch

  • Update your main with the latest upstream version:

    git pull --ff upstream main

Generator development setup

Ionic for JHipster is a JHipster Blueprint.

Here are the most important steps.

Fork the generator-jhipster-ionic project

Go to the generator-jhipster-ionic project and click on the "fork" button. You can then clone your own fork of the project, and start working on it.

Please read the GitHub forking documentation for more information

Set NPM/YARN to use the cloned project

In your cloned generator-jhipster-ionic project, type npm link.

This will do a symbolic link from the global node_modules version to point to this folder, so when you run jhipster-ionic, you will now use the development version of Ionic for JHipster.

For testing, you will want to generate an application, and there is a specific issue here: for each application, Ionic for JHipster installs a local version of itself. This is made to enable several applications to each use a specific Ionic for JHipster version (application A uses Ionic for JHipster 7.1.0, and application B uses Ionic for JHipster 7.2.0).

To overcome this you need to run npm link generator-jhipster-ionic in the generated project folder as well, so that the local version has a symbolic link to the development version of JHipster.

To put it in a nutshell, you need to:

  1. run npm link in the generator-jhipster-ionic project
  2. run npm link generator-jhipster-ionic on the generated application folder (you need to do this for each application you create)

Now, running the jhipster-ionic command should use your specific Ionic for JHipster version. You can test it by making a small change in your cloned generator, and running again on an existing Ionic project:

jhipster-ionic entity <name>

You should see your changes reflected in the generated project.

Coding Rules

To ensure consistency throughout the source code, keep these rules in mind as you are working:

  • All features or bug fixes should be tested by one or more tests.
  • All files must follow the .editorconfig file located at the root of the JHipster generator project. Please note that generated projects use the same .editorconfig file, so that both the generator and the generated projects share the same configuration.
  • Java files must be formatted using Intellij IDEA's code style. Please note that JHipster committers have a free Intellij IDEA Ultimate Edition for developing the project.
  • Generators JavaScript files must follow the eslint configuration defined at the project root, which is based on Airbnb JavaScript Style Guide.
  • Web apps JavaScript files must follow Google's JavaScript Style Guide.
  • TypeScript files must follow Official Angular style guide.

Please ensure to run npm run lint and npm test on the project root before submitting a pull request. You can also run npm run lint-fix to fix some of the lint issues automatically.

Template Guidelines

The template engine used by Yeoman is EJS, its syntax is fairly simple.

Git Commit Guidelines

We have rules over how our git commit messages must be formatted. Please ensure to squash unnecessary commits so that your commit history is clean.

Commit Message Format

Each commit message consists of a header, a body and a footer.

<header>
<BLANK LINE>
<body>
<BLANK LINE>
<footer>

Any line of the commit message cannot be longer 100 characters! This allows the message to be easier to read on GitHub as well as in various git tools.

Header

The Header contains a succinct description of the change:

  • use the imperative, present tense: "change" not "changed" nor "changes"
  • don't capitalize first letter
  • no dot (.) at the end

Body

If your change is simple, the Body is optional.

Just as in the Header, use the imperative, present tense: "change" not "changed" nor "changes". The Body should include the motivation for the change and contrast this with previous behavior.

Footer

The footer is the place to reference GitHub issues that this commit Closes.

You must use the GitHub keywords for automatically closing the issues referenced in your commit.

Example

For example, here is a good commit message:

upgrade to JHipster 4.11.1

upgrade the required version of JHipster to be 4.11.1,
see http://www.jhipster.tech/2017/11/26/jhipster-release-4.11.1.html

Fix #1234