Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to angular 17 and update implementation to new angular standards. #983

Closed
3 of 4 tasks
mshima opened this issue Nov 9, 2023 · 14 comments
Closed
3 of 4 tasks

Comments

@mshima
Copy link
Member

mshima commented Nov 9, 2023

  • drop ngx-webstorage package. It usually takes a few weeks to update and its usage is trivial.
  • update to angular 17
  • convert components to standalone components.
  • Change to new control flow syntax #998
@mraible
Copy link
Collaborator

mraible commented Dec 2, 2023

I'm not sure we should migrate to standalone components for Ionic. I spent some time yesterday trying to migrate @oktadev/schematics to use standalone components for Ionic. I found that I had to import so many components in the tabs page that it was exhausting, and I decided it wasn't work it. https://github.com/oktadev/schematics/pull/1210/files#diff-9c6765d50519f26b8b3344fe553a875ef6d3f21e10215b11291f56f3d39fecc0

@mshima
Copy link
Member Author

mshima commented Dec 7, 2023

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

@mshima I think it'd be good to release a version that works with Node 18 and JHipster 8, then address standalone components afterward. What do you think?

@mshima
Copy link
Member Author

mshima commented Jan 10, 2024

@mraible sure we should not block releases for small improvements.
We need a new release for micronaut and quarkus too if you have permission.

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

@mshima I agree that we should release new JHipster 8 blueprints for Micronaut and Quakus. They both have publish pipelines like this repo, so as soon as we create a new release in GitHub, it publishes it to npmjs.com.

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

The Micronaut blueprint is currently blocked by jhipster/generator-jhipster-micronaut#295 and the Quarkus blueprint is blocked by jhipster/generator-jhipster-quarkus#306.

@mshima
Copy link
Member Author

mshima commented Jan 10, 2024

The Micronaut blueprint is currently blocked by jhipster/generator-jhipster-micronaut#295 and the Quarkus blueprint is blocked by [jhipster/generator-jhipster-quarkus#306]

I think we should release based on micronaut v3 before moving to v4.

(jhipster/generator-jhipster-quarkus#306).

Should be fixed by jhipster/generator-jhipster-quarkus#308

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

I think we should release based on micronaut v3 before moving to v4.

I'm fine with that. Is there anything we need to do for that or is it ready to release? If it's ready, I can do it today.

@mshima
Copy link
Member Author

mshima commented Jan 10, 2024

I think we should release based on micronaut v3 before moving to v4.

I'm fine with that. Is there anything we need to do for that or is it ready to release? If it's ready, I can do it today.

I think you can go ahead.
This week I will do only limited work on mobile.

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

It looks like Micronaut 3 was already released in the v2.0.0.

@mshima
Copy link
Member Author

mshima commented Jan 10, 2024

Yes, but with angular 14 and vue 2.

@mraible
Copy link
Collaborator

mraible commented Jan 10, 2024

So you're saying we should release a v2.1.0 that uses Micronaut 3 and JHipster 8?

@mshima
Copy link
Member Author

mshima commented Jan 10, 2024

Release v3.0.0 which uses micronaut 3 and JHipster v8.0.0

  • drops support for node v12, v14 and v16.
  • add support for node v18 and v20 (currently broken)
  • includes angular 16, vue 3.2 and java 7 by default.

For micronaut v4 we can release blueprint v3.1.0 or v4.0.0.
Ideally we should update to jhipster v8.1.0, but since it’s just create a tag we should do releases more often.

@mraible
Copy link
Collaborator

mraible commented Jan 12, 2024

I'm not sure we need to release a new version with Micronaut 3. I get the feeling that people won't use it because they'll want to use the latest version of Micronaut. JHipster is used to start new projects, and people want to use the latest versions when they start new projects.

According to npmjs.com, the Micronaut blueprint had ~200 downloads when 2.0.0 was released but seems to average < 20 per week since then.

@mraible mraible closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants