Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker deployment for heroku #157

Merged
merged 3 commits into from Aug 11, 2020
Merged

Fix docker deployment for heroku #157

merged 3 commits into from Aug 11, 2020

Conversation

atomfrede
Copy link
Member

This fixes the entrypoint definition for jib (see main generator) and removes the jwt secret environment variable from heroku properties as there is a value now in prod profile

@atomfrede atomfrede requested a review from mraible August 11, 2020 19:12
mraible
mraible approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the GitHub actions warnings.

@atomfrede
Copy link
Member Author

LGTM, except for the GitHub actions warnings.

Forgot to check the linter 🤦 It's fixed now.

@atomfrede atomfrede added the enhancement 💎 New feature or request label Aug 11, 2020
@atomfrede atomfrede merged commit 1bc66a3 into jhipster:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraible mraible mraible approved these changes

Assignees
No one assigned
Labels
enhancement 💎 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atomfrede @mraible