Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service classes in wrong package #312

Closed
emilpaw opened this issue Jan 23, 2024 · 1 comment · Fixed by #313
Closed

Service classes in wrong package #312

emilpaw opened this issue Jan 23, 2024 · 1 comment · Fixed by #313

Comments

@emilpaw
Copy link
Contributor

emilpaw commented Jan 23, 2024

Describe the bug
While working on #311 I noticed that the service classes are placed in the wrong package. Instead of adding them to the service package, they are added to service.impl.

To Reproduce
Generate an application that uses service classes. It doesn't matter if the service classes are created because of the dto or service option.

application {
  config {
    prodDatabaseType postgresql
  }

  entities *
}

entity Category {
  description String required
}
entity Post {
  title String required
}
service Category with serviceClass
dto Post with mapstruct

Expected behavior
The service classes are in the service package and not in impl. All the imports expect the service classes to be in service, and also the base JHipster generator does not use an impl package like that.

@mraible
Copy link
Contributor

mraible commented Jan 24, 2024

@emilpaw Can you please create a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants