Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not used config stored in .yo-rc.json #13412

Closed
pascalgrimaud opened this issue Jan 5, 2021 · 6 comments · Fixed by #13413
Closed

Not used config stored in .yo-rc.json #13412

pascalgrimaud opened this issue Jan 5, 2021 · 6 comments · Fixed by #13413

Comments

@pascalgrimaud
Copy link
Member

Overview of the issue

When generating a microservice application, there are some properties in .yo-rc.json which are incorrect:

    "clientFramework": "angularX",
    "clientTheme": "none",
    "clientThemeVariant": "",
    "withAdminUi": true
Motivation for or Use Case

As there is no front part, these properties should not be here.

Reproduce the error
Related issues
Suggest a Fix
JHipster Version(s)
jhipster@0.0.0 /home/pgrimaud/tmp/18-micro
└── (empty)

JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "blueprints": [],
    "otherModules": [],
    "applicationType": "microservice",
    "baseName": "jhipster",
    "jhipsterVersion": "7.0.0-beta.0",
    "skipClient": true,
    "skipUserManagement": true,
    "skipServer": false,
    "skipCheckLengthOfIdentifier": false,
    "skipFakeData": false,
    "jhiPrefix": "jhi",
    "entitySuffix": "",
    "dtoSuffix": "DTO",
    "testFrameworks": [],
    "pages": [],
    "creationTimestamp": 1609832735305,
    "promptValues": {
      "packageName": "com.mycompany.myapp",
      "nativeLanguage": "fr"
    },
    "serviceDiscoveryType": "eureka",
    "reactive": false,
    "authenticationType": "jwt",
    "packageName": "com.mycompany.myapp",
    "serverPort": "8081",
    "cacheProvider": "hazelcast",
    "enableHibernateCache": true,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "postgresql",
    "buildTool": "maven",
    "serverSideOptions": [],
    "websocket": false,
    "searchEngine": false,
    "messageBroker": false,
    "enableSwaggerCodegen": false,
    "enableTranslation": true,
    "nativeLanguage": "fr",
    "packageFolder": "com/mycompany/myapp",
    "jwtSecretKey": "YourJWTSecretKeyWasReplacedByThisMeaninglessTextByTheJHipsterInfoCommandForObviousSecurityReasons",
    "languages": ["fr"],
    "clientFramework": "angularX",
    "clientPackageManager": "npm",
    "clientTheme": "none",
    "clientThemeVariant": "",
    "withAdminUi": true
  }
}
JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

Environment and Tools

openjdk version "11.0.9.1" 2020-11-04
OpenJDK Runtime Environment (build 11.0.9.1+1-Ubuntu-0ubuntu1.18.04)
OpenJDK 64-Bit Server VM (build 11.0.9.1+1-Ubuntu-0ubuntu1.18.04, mixed mode, sharing)

git version 2.30.0

node: v14.15.3

npm: 6.14.9

yeoman: 3.1.1

Docker version 19.03.8, build afacb8b7f0

docker-compose version 1.27.3, build 4092ae5d

INFO! Congratulations, JHipster execution is complete!

@mshima
Copy link
Member

mshima commented Jan 7, 2021

Reopening to track same problem with skipServer/skipClient related to #13058 (comment).

@mshima mshima reopened this Jan 7, 2021
@mshima
Copy link
Member

mshima commented Jan 19, 2021

I've tried to fix this by using jdl defaults methods, but jdl has the same problem:

$ jhipster jdl --inline 'application { config { skipClient true } }' --json-only
$ cat .yo-rc.json | grep client
    "clientFramework": "angularX",
    "clientPackageManager": "npm",
    "clientTheme": "none",
    "clientThemeVariant": "",

Same for skipServer for configurations like cacheProvider:

$ jhipster jdl --inline 'application { config { skipServer true } }' --json-only
$ cat .yo-rc.json
{
  "generator-jhipster": {
    "authenticationType": "jwt",
    "cacheProvider": "ehcache",
    "clientFramework": "angularX",
    "serverPort": "8080",
    "serviceDiscoveryType": false,
    "skipUserManagement": false,
    "withAdminUi": true,
    "baseName": "jhipster",
    "buildTool": "maven",
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",

I will wait for jdl defaults to be fixed first.

@mshima mshima changed the title Wrong config for microservices in .yo-rc.json Not used config stored in .yo-rc.json Jan 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud
Copy link
Member Author

Still todo

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud
Copy link
Member Author

I think it's solved, for unknown reason :-D
So it can be closed

@pascalgrimaud pascalgrimaud added this to the v7.0.1 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@mshima @pascalgrimaud and others