Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate entities generators into each feature specific generator. #19111

Closed
6 of 7 tasks
mshima opened this issue Jul 8, 2022 · 4 comments · Fixed by #19930
Closed
6 of 7 tasks

Integrate entities generators into each feature specific generator. #19111

mshima opened this issue Jul 8, 2022 · 4 comments · Fixed by #19930
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: jhipster-internals v8 $300 https://www.jhipster.tech/bug-bounties/
Milestone
8.0.0-beta.1

Comments

@mshima
Copy link
Member

mshima commented Jul 8, 2022 •
edited by DanielFran
Loading

Overview of the feature request

Implement RFC https://github.com/jhipster/generator-jhipster/blob/main/rfcs/4-jhipster-rfc-entity-as-core.md.

  • entities
  • entities-client
  • entity
  • entity-client
  • entity-i18n
  • entity-server
Motivation for or Use Case

Improve developer experience.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@mshima mshima changed the title Integrate entities generators into each base generator. Integrate entities generators into each feature specific generator. Jul 8, 2022
@mshima mshima mentioned this issue Aug 1, 2022
Closed
@deepu105 deepu105 added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ labels Aug 4, 2022
@Tcharl
Copy link
Contributor

Tcharl commented Aug 8, 2022

Just a remark on the syntax: most of the methods are using the 'Each' keyword to tell that this method to specify that it will impact the whole entity pool. The only exception being 'writingEntities' which uses plural. Could it be possible to align (e.g. using 'Each' or plural everywhere)?

This was referenced Sep 14, 2022
Merged
Merged
Merged
This was referenced Sep 22, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 1, 2022
Merged
Merged
Merged
@mshima
Copy link
Member Author

mshima commented Jan 26, 2023

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/120305

@DanielFran
Copy link
Member

@mshima approved

@mshima
Copy link
Member Author

mshima commented Jan 26, 2023

@DanielFran that was quick, thanks. 😄

@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: jhipster-internals v8 $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
8.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Integrate entity-* generators into client/server/languages. mshima/generator-jhipster
4 participants
@Tcharl @deepu105 @mshima @DanielFran