Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.devcontainer for the JHipster generator repository itself to automatically install supported java and npm version when I want to contribute to JHipster #22762

Closed
SandraAhlgrimm opened this issue Jul 3, 2023 · 11 comments · Fixed by #22814
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@SandraAhlgrimm
Copy link
Contributor

To make contributions to the jHipster generator easier and to welcome more new contributors, having a devcontainer in the generator repo itself makes sense.

"I would also like a .devcontainer for the JHipster generator repository itself to automatically install supported java and npm version when I want to contribute to JHipster"

Originally posted by @CodingSpiderFox in #17612 (comment)

@atomfrede
Copy link
Member

Would you like to take the lead here? I guess you have most experience with it, @jdubois what do you say?

@jdubois
Copy link
Member

jdubois commented Jul 3, 2023

Oh that's great, yes let's do this with @SandraAhlgrimm (to be transparent: I'm Sandra's manager at Microsoft )

@atomfrede
Copy link
Member

I know, that's why I pinged you :)

@SandraAhlgrimm
Copy link
Contributor Author

SandraAhlgrimm commented Jul 3, 2023

sure, I am happy to start this @atomfrede

@mraible
Copy link
Contributor

mraible commented Jul 10, 2023

Adding a bug bounty since this seems like a nice feature to have.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ and removed area: triage theme: undefined labels Jul 10, 2023
@jdubois
Copy link
Member

jdubois commented Jul 10, 2023

Thanks @mraible but if this is done by @SandraAhlgrimm I’m afraid this might rise a conflict of interest on the Microsoft side

@mraible
Copy link
Contributor

mraible commented Jul 10, 2023

@jdubois It looks like @mshima has started working on it in #22814. I'm not sure how complete it is.

@mshima
Copy link
Member

mshima commented Jul 11, 2023

Sorry if I stepped up in front of @SandraAhlgrimm, there are a few more vscode customizations other than devcontainer that needed documentation like #19849 (comment).

  • generator-hipster devcontainer is using the same version workflows and generated applications uses for node, npm and java.
  • updated generated application devcontainer.
  • added documentation for samples generation shortcuts.
  • added documentation for test, which uses mocha explorer.
  • added jit executable (which I hardly recommend and use).
  • a few more documentation adjusts.

I've started to playing with code-workspace for jhipster-samples folder, looks promising.

@DanielFran DanielFran added this to the 8.0.0-beta.2 milestone Jul 12, 2023
@mshima
Copy link
Member

mshima commented Jul 13, 2023

Anyone knows if it's possible to execute a script before building the devcontainer?
We should create ../jhipster-samples and node_modules_container folders to be mounted.

@mshima
Copy link
Member

mshima commented Sep 28, 2023

@DanielFran
Copy link
Member

@mshima approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants