Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDL support for filtering is missing in 4.7.0 #6286

Closed
1 task done
shekvl opened this issue Aug 24, 2017 · 10 comments
Closed
1 task done

JDL support for filtering is missing in 4.7.0 #6286

shekvl opened this issue Aug 24, 2017 · 10 comments
Assignees
Milestone

Comments

@shekvl
Copy link

shekvl commented Aug 24, 2017

Overview of the issue

In 4.7.0, jdl-import generator does not create "jpaMetamodelFiltering": true entries in .jhipster/*.json files (enabling criteria query generation), and there seems to be no way currently to enable such generation from JDL.

Motivation for or Use Case

Without this functionality, it is not possible to correctly update filtering-enabled entities from JDL, as, after every update, the filtering support is switched off (as it defaults to "no").

Reproduce the error

Run jhipster import-jdl with any JDL file and check the resulting .json files.

Related issues
Suggest a Fix

The option like

filtering for <entity-name | *>

can be added to the JDL syntax. Such option, if enabled, should lead to the generation of the "jpaMetamodelFiltering": true entry in .json file for the corresponding entity.

JHipster Version(s)

4.7.0

  • Checking this box is mandatory (this is just to show you read everything)
@deepu105
Copy link
Member

ping @MathieuAA

@deepu105
Copy link
Member

@shekvl the feature is not supported by JDL yet

@MathieuAA
Copy link
Member

@deepu105 Roger that, I'll handle it

@jdubois
Copy link
Member

jdubois commented Aug 28, 2017

Thanks @MathieuAA -> I'm closing this here as this should be handled in jhipster-core

@jdubois jdubois closed this as completed Aug 28, 2017
MathieuAA pushed a commit to jhipster/jhipster-core that referenced this issue Aug 28, 2017
@jdubois jdubois modified the milestone: 4.8.0 Sep 12, 2017
@colameo
Copy link
Member

colameo commented Oct 28, 2017

is the keyword 'for' in the 'filter' optional or mandatory?

see example and documentation

They can be used like this: <OPTION> <ENTITIES | * | all> except? <ENTITIES>

in other words, which statement is correct 1 or 2:

entity A
entity B

  1. filter * except B
  2. filter for * except B

@ruddell
Copy link
Member

ruddell commented Oct 28, 2017

@colameo The word for is not allowed with filter. Only statement 1 is correct. Please use gitter or stack overflow for questions in the future, this is an issue tracker.

@colameo
Copy link
Member

colameo commented Oct 29, 2017

ok, thanks @ruddell

@colameo
Copy link
Member

colameo commented Oct 29, 2017

...hm, the documentation is a bit unclear as the 'for' word is allowed for the following options:

skipClient
skipServer
noFluentMethod

...but not for filter.

@ruddell
Copy link
Member

ruddell commented Oct 29, 2017

@colameo I see your point, it doesn't really make sense why some keywords use for while others do not. I answered based on what worked when importing JDL, JDL Studio should also highlight invalid JDL. This looks like an issue to take up in the jhipster-core project

@MathieuAA MathieuAA self-assigned this Oct 30, 2017
@MathieuAA
Copy link
Member

I'll fix it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants