Prettier runs too late and causes conflicts during re-generation

[gmarziou]

Currently, prettier runs after code generation.

Due to this, when re-generating an entity or an app, yeoman shows many conflicts (~25% of generated files) only due to reformatting that runs later.

I don't know enough yeoman to say whether it is easy to run prettier after template rendering and before yeoman compares file contents.

[deepu105]

I was also thinking about doing that and I guess it should be possible using the yeoman pipe feature. I'll look into this later

[gmarziou]

I have something starting to work by using yeoman registerTransformStream(), for now it only uses default settings, I must pass it our configuration

gmarziou@b88051b

[deepu105]

Nice work. I assume it would be easy to pass our settings. I didn't look at the code yet, but assume you will be using gulp filters

…

On Fri, 9 Mar 2018, 2:58 am Gaël Marziou, ***@***.***> wrote: I have something starting to work by using yeoman registerTranformStream(), for now it only uses default settings, I must pass it our configuration ***@***.*** <gmarziou@b88051b> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7172 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF2qzUgoJKpSFuetPbSV-poNNqsfwks5tceGqgaJpZM4SSTn0> .

[gmarziou]

Yes I used gulp-filter, I also used gulp-prettier but I had to modify its code a little so finally I rewrote it as a short inner function

[gmarziou]

@deepu105 there's a bootstrap issue here: .prettierrc is generated from an EJS template, so on first generation it does not exist yet and on next generations it exists but could have been customized by user with merge conflicts.

I don't know what I could do with yeoman's in-memory filesystem.

A simple approach could be to define our .prettierrc file as a plain file not a template and that user's configuration file is ignored during generation.

[gmarziou]

I could not find a way to specify a configuration file path through API so I may do the reverse: defining options in a variable and generating the .prettierrc file from it.

[deepu105]

Can you create a PR with what you hv so far, ill work on it tomorrow. I'll find a way

…

On Fri, 9 Mar 2018, 7:22 pm Gaël Marziou, ***@***.***> wrote: I could not find a way to specify a configuration file path through API so I may do the reverse: define options in a variable and generate the .prettierrc file from it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7172 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlFxJZyZMRLd0jT7aofykvCtCsg-m8ks5tcshcgaJpZM4SSTn0> .

[gmarziou]

Here it is, I added it only to app generator.