Improve local travis build

[JulioJu]

Overview of the issue

The script build-sample.sh is totally broken.

Motivation for or Use Case

It's not cool because this script is advised at https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md#local-travis-build.

Reproduce the error

One (error)

1. $ git clone https://github.com/jhipster/generator-jhipster
2. $ cd generator-jhipster
3. $ yarn link
4. $ rm -R generators # (should cause some problems)
5. $ cd travis
6. $ ./build-samples.sh build ngx-default

Weird! All work fine!

EDIT:

1. $ git clone https://github.com/jhipster/generator-jhipster
2. $ echo "<div>coucou</div>" >> generator-jhipster/generators/client/templates/angular/src/main/webapp/app/home/home.component.html.ejs
3. $ cd generator-jhipster
4. $ yarn link
5. $ cd travis
6. $ ./build-samples.sh generate ngx-default
7. $ cat samples/ngx-default-sample/src/main/webapp/app/home/home.component.html | tail

Weird! We have not <div>coucou</div> generated at the end of the file!

Two (suggestion)

As explained in #7311, all travis/script/*.sh are not executed, contrary to remote travis. If you want, correct this.

Three (suggestion)

Add set -ex in all travis/**/*.sh files

• -x option: « trace for each command after it expands the command and before it executes it » to see accurately where there is a bug.
  You could see the result for example at https://travis-ci.org/jhipster/generator-jhipster/builds/365781563?utm_source=github_status&utm_medium=notification. It displays a + sign before each bash command executed. More accurate to see where the script bug !

• -e option: When this option is on, when any command fails (…) the shell immediately shall exit with the following exceptions: so delete some echo $? in file 05-run.sh

Related issues

As explained in #7311 and in #7449 (with @deepu105, @pascalgrimaud, @gmarziou, @jdubois)

Suggest a Fix

If you want tomorrow I could make a PR for that. I have an idea.

JHipster Version(s)

Maybe this error is introduced for all local travis except ng2-gateway-uaa build by https://github.com/jhipster/generator-jhipster/blob/f2c488eae52ea6d49323a9871884ffeaf0ba8a59/travis/scripts/02-generate-project.sh, then introduced for ng2-gateway-uaa by e617fbf#diff-7f1c6970f1f47199abaa8a27c1d2e643

JHipster configuration

Irrelevant

• Checking this box is mandatory (this is just to show you read everything)

[jdubois]

I don't have much issue with it, but I don't use it a lot (I have my own tests), so I'm not the best person to judge.
Anyway, it's very, very important to have the best experience possible for contributors, so if you can improve it, don't hesitate to! Ping @pascalgrimaud for help, he's the expert on this part.

And @JulioJu you're contributing quite a lot recently, and I see you are french: are you coming to Devoxx next week? Or to JHipster Conf in June (I could have a free ticket for you)?

[JulioJu]

@jdubois
Thanks for very much for your invitation ;-) ! It's a very big honour :-).

I've seen the programm… Too much interesting subjects ;-).

I would like answer « yes » to your invitation. But actually I'm a beginner, only a student. 16 days ago I didn't know how work with Travis. And on my last PR there is a Travis bug than I don't still understand.

I'm from Grenoble, so I'm going to meet @gmarziou at a meetup on 25th of april ;-) !

I would like accept your invitation. But if finally it's not possible I understand well. But If you have still ticket I'm going to be very happy to come.

[gmarziou]

@JulioJu I'll be happy to meet you in real life :)

[pascalgrimaud]

@JulioJu : as Julien, I don't use this script but indeed, the issues you mentioned seem correct, specially about yarn link.

So yes, go ahead and PR plz, I will review it.

[pascalgrimaud]

@JulioJu : about experience. In Open Source project, we don't care about that. Everyone can come and contribute :)

[JulioJu]

@gmarziou thanks me too ;-).
@pascalgrimaud thanks ;-). I hope don't commit to much beginner errors ;-). Ok I'm going to work on a PR.

[jdubois]

@JulioJu we have lots of students contributing to JHipster, and really we don't care at all about your experience - it's even forbidden by our code of conduct.
If you want to come to JHipster Conf in Paris, don't hesitate to contact me privately (see http://www.julien-dubois.com/contact.html ).

[JulioJu]

@jdubois thanks a lot again ;-) ! I'm going to send you an email for the JHipster conf in june ;-).

[deepu105]

closing the issue as the PR is in progress and it can be tracked there

[JulioJu]

Change the title. See explanations at #7484 (comment).