[documentation] Add missing JDL field validation for unique constraint

[DanielFran]

Overview of the issue

Reviewing JDL documentation I discover that the unique constraint implementation in jhipster-core project has never been documented in JDL documentation.

Motivation for or Use Case

A new feature since v.4.13.0 & v5.0.0.beta2 that seems not documented (#6678 + #6850 + #6860):
f2e3673
baaa043

Note: The PR jhipster/jhipster.github.io#520 has been merged in create entity documentation but I think it is missing the documentation in JDL part.

• Checking this box is mandatory (this is just to show you read everything)

[DanielFran]

@MathieuAA I did not found any reference in https://github.com/jhipster/jhipster.github.io/blob/master/pages/jdl.md.
Do you want I PR to add the information?

Does the issue jhipster/jhipster-core#18 should be closed?

[MathieuAA]

Is it finally in the generator?! I have a branch already for this... I'll find time to merge it and add the doc

[deepu105]

I'm not sure, will need to look at code. But I think it wad reverted at some point due to issues

…

On Wed, 26 Sep 2018, 7:29 am Mathieu ABOU-AICHI, ***@***.***> wrote: Is it finally in the generator?! I have a branch already for this... I'll find time to merge it and add the doc — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8403 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF12USQPZiLed37xQgJnv9uYH1kh6ks5uexCggaJpZM4W5jzs> .

[MathieuAA]

Well, once it's in the generator and enabled, feel free to reach me so that I can do my part. Thanks :)

[DanielFran]

@deepu105 @MathieuAA Confirmed for the 2 pull request on generator side:
Related for this commit f2e3673
OK in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity-server/templates/src/main/resources/config/liquibase/changelog/added_entity.xml.ejs:

• https://github.com/jhipster/generator-jhipster/blob/master/generators/entity-server/templates/src/main/resources/config/liquibase/changelog/added_entity.xml.ejs#L62-L65
• https://github.com/jhipster/generator-jhipster/blob/master/generators/entity-server/templates/src/main/resources/config/liquibase/changelog/added_entity.xml.ejs#L113-L116

KO in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js:

• https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js#L722-L725
• (...)
  Because it was Temporarily remove the "unique" option in the questions by @jdubois ad66b9c

Related for this commit baaa043
OK in https://github.com/jhipster/generator-jhipster/blob/master/travis/samples/.jhipster/Division.json:

• https://github.com/jhipster/generator-jhipster/blob/master/travis/samples/.jhipster/Division.json#L23-L24
• https://github.com/jhipster/generator-jhipster/blob/master/travis/samples/.jhipster/Division.json#L29-L32

So we need to take care of the missing changes in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js

[MathieuAA]

Roger that. Thanks for the heads up

[DanielFran]

@jdubois To reactivate prompts for "unique" field validation, can you please re-revert ad66b9c or should I do a PR for this?

[jdubois]

@DanielFran I'm reverting the commit right now

[DanielFran]

@MathieuAA I think that you can merge your changes and create the PR for the JDL documentation ;)

[jdubois]

@DanielFran sorry I can't revert the commit easily, there's a conflict, give me some time :-)

[DanielFran]

@MathieuAA You can proceed with the merge of unique validation in Core project since @jdubois already merge the missing prompts in the generator.
Do not forget to add the documentation in JDL part.
Thanks

[MathieuAA]

Okay!Le 3 oct. 2018 23:40, Daniel Franco <notifications@github.com> a écrit :@MathieuAA You can proceed with the merge of unique validation in Core project since @jdubois already merge the missing prompts in the generator. Do not forget to add the documentation in JDL part. Thanks —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

[DanielFran]

@MathieuAA Just to confirm with you if you already do the PR for to update of JDL documentation?
This issue is still open waiting for your confirmation....

[MathieuAA]

I don't have much time nowadays to do anything, but it's merged. I'll do the doc during the weekendLe 12 oct. 2018 18:04, Daniel Franco <notifications@github.com> a écrit :@MathieuAA Just to confirm with you if you already do the PR for to update of JDL documentation? This issue is still open waiting for your confirmation.... —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

[MathieuAA]

The PR has been submitted.

[DanielFran]

Closed with jhipster/jhipster.github.io#641