Redis cache support

[Shaolans]

• Please make sure the below checklist is followed for Pull Requests.

• Travis tests are green

• Tests are added where necessary

• Documentation is added/updated where necessary

• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

This is my implementation of redis cache for the generator. Here you can check a example of an application generated with redis cache https://github.com/Shaolans/jhipster-app-redis-sample.
It uses this branch of Jhipster jhipster/jhipster#324.
Fix #9280

[hdurix]

Great! I tried it and the cache is correctly used.

2 other things:

• you could change the logger for redisson <logger name="org.redisson" level="WARN"/> as it's done for infinispan (a lot of logs are currently shown)
• it would be nice to have the information in the readme that a redis instance has to be launched with Docker Compose in order to start the app

[hdurix]

@Tcharl @jdubois @anthonyrichir @PierreBesson could you have a look at this PR?

[PierreBesson]

There is something strange. It looks like the jhipsterProperties doesn't have the property: redis.enabled like what was done for memcached. I think we should stay consistent between the 2 implementations.

[Shaolans]

@PierreBesson We currently only supporting enabling/disabling cache on memcached not for others. Memcached is using Spring Cache and it exists NoOpCacheManager in order to disable the caching. However since this implementation is using JCache I am not sure if we have something similar.

[DanielFran]

Normally it is just necessary to add to app.yml:

spring:
  cache:
    type: none

See https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-caching.html#boot-features-caching-provider-none

[hdurix]

So nothing to do in our hand? Except maybe to explain it in the README?

[Shaolans]

@DanielFran Nice thanks !

@hdurix I think so, here we just need to avoid to instantiate a RedisClient when the cache is none but if the cache is disabled, the user should also manually disable hibernate 2nd cache level if there is one since hibernate share the same CacheManager

[DanielFran]

@Shaolans I do not believe you need to add your last commit since the cache will not be used if deactivated in configuration file.
I believe we just need to document it and make reference to spring documentation.

[Shaolans]

@DanielFran Even if we disable the cache, I think it will still instantiate a redis client and the HibernatePropertiesCustomizer bean will error since there is no cacheManager. Or is it up to the dev to do it ?

EDIT: I removed the commit.

[JackyC415]

@Shaolans I'm just wondering how you were able to build the project when getRedis() is undefined? Thanks.

[Shaolans]

@JackyC415 Hello you need to build the jhipster server library first by running ./mvnw clean install -Dgpg.skip=true -DskipTests on this branch jhipster/jhipster#324

[pascalgrimaud]

@Shaolans : just tested it and it works well. Good job ! But I have a comment:

• it looks like I need to start a Redis server before lauching tests, otherwise, all tests will fail
• is it the case ? Can't we use an embedded Redis server or maybe use testcontainers ?

[pascalgrimaud]

Another comments too:

• the docs at jhipster.tech need to be updated too
• the option should work for JDL

[pascalgrimaud]

If possible, once it's merged, if you can add a dedicated build at https://github.com/hipster-labs/jhipster-daily-builds it would be great !

[Shaolans]

it looks like I need to start a Redis server before lauching tests, otherwise, all tests will fail
is it the case ? Can't we use an embedded Redis server or maybe use testcontainers ?

You are totally right ! @pascalgrimaud According to you which one do you think we should use ?

the docs at jhipster.tech need to be updated too

I was planning on doing it, if the PR was good enough.

the option should work for JDL

Thanks for reminding me it, I totally forgot that case.

If possible, once it's merged, if you can add a dedicated build at https://github.com/hipster-labs/jhipster-daily-builds it would be great !

I was planning do it, once merge :) !

I will probably work on these points next week.

[pascalgrimaud]

@Shaolans : Thanks. What I prefer in order:

• I don't look how memcached works, it would be nice to be consistent
• embedded server
• disable cache for tests
• testcontainer

[DanielFran]

@jdubois Do you have time to review this PR since you were interested in?

[TonyLuo]

any update on this? seems still not merged into master branch yet...

[pascalgrimaud]

@TonyLuo : there is still an issue with integration tests, that's why it's not ready to be merged yet

[atomfrede]

Good work @Shaolans really looking forward to have it merged!

[pascalgrimaud]

Very good job @Shaolans !

[Shaolans]

Bug bounty claimed https://opencollective.com/generator-jhipster/expenses/10211

[sinaghazi]

for some reason on version v6.10.4 I faced an issue with ExtendWith annotation not being imported in the AccountResourceIT class. My config is Okta and i used Redis for cache.

[pascalgrimaud]

@sinaghazi : plz open a new ticket with all information so we can try to reproduce