Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip App questions to reduce and customize general prompt #10493

Closed
wants to merge 9 commits into from
Closed

Skip App questions to reduce and customize general prompt #10493

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2019

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@ghost ghost changed the title Resolve issue #10482 Skip App questions to reduce and customize general prompt Sep 25, 2019
@ghost
Copy link
Author

ghost commented Sep 25, 2019

PR for #10482

@murdos
Copy link
Contributor

murdos commented Oct 10, 2019

FYI there's another solution proposed to fix the same issue: #10586

@ghost
Copy link
Author

ghost commented Oct 10, 2019

Thanks @murdos, this is a good solution in order to provide a full customization...but my solution is only to skip some question prompts without customize any subgenerator, and it not exclude that you have referenced.

@avdev4j
Copy link
Contributor

avdev4j commented Oct 15, 2019

hi,
If we can customize questions, that's mean we can skip which we don't want to display to the user. That's why I prefer to avoid adding many and many skip options for adding a full solution to customize prompts and get benefit for all other blueprints.

So I suggest to help @mshima to secure his PR and contribute to a more complete solution.

@ghost
Copy link
Author

ghost commented Oct 15, 2019

ok @avdev4j , what does miss in that PR?

@mshima mshima mentioned this pull request Oct 15, 2019
4 tasks
@avdev4j
Copy link
Contributor

avdev4j commented Oct 15, 2019

First we need to help for the review and try to how test and (if needed) improve the code.
I think we can converge for a more generic solution.

@murdos
Copy link
Contributor

murdos commented Oct 15, 2019

I agree, I prefer a more generic solution too.

@pascalgrimaud
Copy link
Member

I think it can be closed as #10752 should help to customize app question

@pascalgrimaud pascalgrimaud added this to the 6.6.0 milestone Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants