Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot adjustments #11988

Merged
merged 1 commit into from Jun 25, 2020
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 25, 2020

  • PR branchs considers target branch.
  • On conditions don’t show at actions list.
  • dependabot builds are duplicating at dependabot/* branch and PR

Copy link
Member

@SudharakaP SudharakaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshima : This PR seems to handle dependabot CI skipping in an alternative manner; not using the if condition as I did in #11988. I would suggest using one method to be consistent. As such,

How about we change all files angular.yml, gradle-wrapper-validation-yml, react.yml and webflux.yml to have,

on:
    push:
        branches-ignore:
            - 'dependabot/**'
on:
    pull_request:
        branches-ignore:
            - 'dependabot/**'

And remove the if conditions. wdyt? 😄

@SudharakaP
Copy link
Member

SudharakaP commented Jun 25, 2020

Also my suggestion above will skip the branches when merged to master too; but do we really need to have the CI running on master for something we don't check before merging. I would suggest that's not quite optimal right? After all we should probably check what we check before merging not after merging. 😄

@mshima
Copy link
Member Author

mshima commented Jun 25, 2020

And remove the if conditions. wdyt? 😄

on:
    pull_request:
        branches-ignore:
            - 'dependabot/**'

Doesn’t work branches-ignore matches target branch only, should be master in this case.

@SudharakaP
Copy link
Member

And remove the if conditions. wdyt? smile

on:
    pull_request:
        branches-ignore:
            - 'dependabot/**'

Doesn’t work branches-ignore matches target branch only, should be master in this case.

@mshima : Ah, got it. This is the same case with Azure which I got to know later. 😄

@SudharakaP SudharakaP merged commit 1d4da7b into jhipster:master Jun 25, 2020
@pascalgrimaud pascalgrimaud added this to the 6.10.0 milestone Jun 27, 2020
@mshima mshima deleted the dependabot_adjusts branch June 27, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants