-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webflux] Re-enable blockhound and whitelist BoundedElasticScheduler.schedule #12736
Conversation
acddb15
to
0fcb7d5
Compare
@@ -0,0 +1 @@ | |||
<%= packageName %>.config.JHipsterBlockHoundIntegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use @AutoService
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure adding yet another dependency and another annotation processor is worth the value here, for something that is supposed to be a temporary workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a file that will need to be cleaned up later doesn't seem better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does really cleaning one file (JHipsterBlockHoundIntegration.java
) or two files (JHipsterBlockHoundIntegration.java
+ meta-inf service declaration) makes a difference?
On the other hand, we have to deal with adding a new dependency (com.google.auto.service:auto-service-annotations
), a new annotation processor (com.google.auto.service:auto-service
) and a new property for the version that will have to be updated from time to time, for 2 build systems (gradle and maven).
I'm really not convinced here, in this context, with the use of @Autoservice
, but I can add it others think it's the better solution.
@jhipster/developers what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass - ship it! 🚢
LGTM. Feel free to merge @murdos |
Bounty claimed: https://opencollective.com/generator-jhipster/expenses/59178 |
@murdos : approved |
Fixes #11599
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.