-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change jdl to don't set nativeLanguage and languages if not present in jdl. #12810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the user has to specify a language if the locale one isn't the right one? all the time?
I don't think it's a good idea...
Why is better to set 'en' then guessing from user locale? |
Unless the user explicitly asks for a language, getting it fro the OS's locale may not work: my locale's set to French, but my apps are always in English. |
f5ff471
to
da9b09b
Compare
@MathieuAA dropped user language. |
You just need to set your apps native language and languages at jdl. Having default to user locale should mainly influence at examples like |
I didn't follow closely what is done here, but in my opinion, the command If it's different because of local, we'll have a lot of difficulty to reproduce, to guess the locale of the user etc... Just my opinion |
@pascalgrimaud I planning to merge this PR so we can change the generator to make
Your concern is valid I will think about this. |
fine @mshima : I'm commenting the other ticket |
Closes #12809.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.