Simplify Code AccountResource #12922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
requested changes
Oct 31, 2020
| throw new InvalidPasswordException(); | ||
| } | ||
| <%_ if (!reactive) { _%> | ||
| Optional<<%= asEntity('User') %>> user = | ||
| userService.completePasswordReset(keyAndPassword.getNewPassword(), keyAndPassword.getKey()); | ||
|
|
||
| if (!user.isPresent()) { | ||
| if (user.isEmpty()) { |
There was a problem hiding this comment.
We're still supporting Java8, so we can't use this newer API
| @@ -377,7 +377,7 @@ public class AccountResource { | |||
| */ | |||
| @PostMapping(path = "/account/change-password") | |||
| public <% if (reactive) { %>Mono<Void><% } else { %>void<% } %> changePassword(@RequestBody PasswordChangeDTO passwordChangeDto) { | |||
| if (!checkPasswordLength(passwordChangeDto.getNewPassword())) { | |||
| if (checkPasswordLength(passwordChangeDto.getNewPassword())) { | |||
There was a problem hiding this comment.
I'm not convinced that inverting the meaning of checkPasswordLength is an improvement.
Or propose a new meaningful name for this method as e.g. isPasswordLengthInvalid
|
Please consider squashing your commits and git force pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean method 'checkPasswordLength' is always inverted
Inspection info: Reports methods with a boolean return type, which are only used in a negated context
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.