Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split AccountResourceIT template #12985

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Nov 8, 2020

The template was very big and was in fact the aggregation of 3 templates for oauth2, skipUserManagement and other cases


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

The template was very big and was the aggregation of 3 templates for oauth2, skipUserManager and other cases
@mshima
Copy link
Member

mshima commented Nov 8, 2020

For consistency would be nice to have ${option}Filename or Filename_${option}.
This PR uses the second, database changes uses the first.
I prefer the second if it will drop the option from name.

@murdos
Copy link
Contributor Author

murdos commented Nov 8, 2020

For consistency would be nice to have ${option}Filename or Filename_${option}.
This PR uses the second, database changes uses the first.
I prefer the second if it will drop the option from name.

Good point. I agree that the second is better. I'll do another PR that fixes database configuration and also other templates like reactive ones.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit 0743172 into jhipster:main Nov 8, 2020
@murdos murdos deleted the split-AccountResourceIT branch November 8, 2020 14:29
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants