-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split UAA SecurityConfiguration in a distinct template #12986
Split UAA SecurityConfiguration in a distinct template #12986
Conversation
@@ -845,16 +855,6 @@ const serverFiles = { | |||
}, | |||
], | |||
}, | |||
{ | |||
condition: generator => !generator.reactive && generator.authenticationType === 'oauth2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was redundant with
generator-jhipster/generators/server/files.js
Line 450 in 9ce17c1
condition: generator => !generator.reactive && generator.applicationType !== 'uaa' && generator.authenticationType !== 'uaa', |
Great work on config files reorganisation. Not convinced about the security folder though. Same for database config, having |
And rename ReactiveSecurityConfiguration template to follow pattern TargetFilename_${option}
9ce17c1
to
ed4f74a
Compare
I've reverted the move to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I love what you're doing @murdos |
@pascalgrimaud: thanks! |
And move security related templates in a dedicated template directory
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.