[vue] let dependabot manage some vue dependencies #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomfrede
added
theme: dependencies
murdos
reviewed
Nov 9, 2020
|
|
atomfrede
force-pushed
the
let-dependabot-manage-some-vue-dependencies
branch
from
e297eb9
to
f04a8f2
Compare
murdos
reviewed
Nov 9, 2020
pascalgrimaud
requested changes
Nov 10, 2020
mshima
reviewed
Nov 10, 2020
…side package.json
atomfrede
force-pushed
the
let-dependabot-manage-some-vue-dependencies
branch
from
20e87e4
to
7ade66c
Compare
pascalgrimaud
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #12972
It uses husky and lint-staged from constants, updates some vue dependencies where possible and save (e.g. terser plugin 5.x is not compatible with webpack 4). Some of the common dependencies are can now be managed by dependabot. Didn't put vue core on purpose yet until we are on vue3.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.