Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master branch to main in the the heroku sub-generator #13013

Merged

Conversation

SudharakaP
Copy link
Member

The heroku sub-generator still seems to use the master branch instead of main. This resolves that.

Related to #12718 and #11935


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

The heroku sub-generator still seems to use the master branch instead of main. This resolves that.
@pascalgrimaud
Copy link
Member

I didn't change it because I don't know how works the git repository at Heroku
Did they change their default branch to main, as GitHub did ?

@SudharakaP
Copy link
Member Author

SudharakaP commented Nov 10, 2020 via email

@pascalgrimaud
Copy link
Member

oh cool, so let's go !

@pascalgrimaud pascalgrimaud merged commit 59ed446 into jhipster:main Nov 10, 2020
@SudharakaP SudharakaP deleted the change-heroku-push-branch-name branch November 10, 2020 07:30
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants