Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error messages when encountering invalid tokens #13030

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Improved error messages when encountering invalid tokens #13030

merged 2 commits into from
Nov 12, 2020

Conversation

MathieuAA
Copy link
Member

@MathieuAA MathieuAA commented Nov 11, 2020 •
edited

Please make sure the below checklist is followed for Pull Requests.

Fixes #13029

mraible
mraible requested changes Nov 11, 2020
View reviewed changes
jdl/parsing/api.js Outdated Show resolved Hide resolved
test/jdl/grammar/validator.spec.js Outdated Show resolved Hide resolved
test/jdl/grammar/validator.spec.js Outdated Show resolved Hide resolved
test/jdl/grammar/validator.spec.js Outdated Show resolved Hide resolved
test/jdl/grammar/validator.spec.js Outdated Show resolved Hide resolved
test/jdl/jdl-importer.spec.js Outdated Show resolved Hide resolved
@MathieuAA
Copy link
Member Author

Thanks for reviewing everything :)

@MathieuAA MathieuAA merged commit 0eccec4 into jhipster:main Nov 12, 2020
@MathieuAA MathieuAA deleted the fix-13029 branch November 12, 2020 07:09
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraible mraible mraible approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

Improve the error message about JDL options that don't exist
3 participants
@MathieuAA @mraible @pascalgrimaud