fix heroku reprompting for app name when not found #13039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Heroku app is not found, the user is prompted to re-run
jhipster heroku
to create a new deployment. To enable regenerating the Heroku deployment, theherokuAppName
config is set tonull
.The config is later saved with the value of
this.herokuAppName
in thesaveConfig
step, rather thannull
.This commit fixes the behavior. Now, when an app is not found, re-running
jhipster heroku
prompts you to create a new deployment. It also skips other steps when finding the app fails (such as editing the pom.xml).Related to this StackOverflow question