Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove system and anonymoususer #13043

Merged
merged 1 commit into from Nov 19, 2020

Conversation

ctamisier
Copy link
Contributor

Remove system and anonymoususer as they are not used in a generated application.

For auditing, the system string is used as the editor when the action is not performed by a real connected user (SpringSecurityAuditorAware.java).
system user was a "loggable" user.

When a reset password action is triggered, the string anonymousUser is used ('U' uppercase) and it is not related with the current anonymoususer user.

So everything seems safe to remove these 2 default accounts.

@ctamisier ctamisier changed the title refactor: remove system and anonymoususer fix: remove system and anonymoususer Nov 15, 2020
@ctamisier ctamisier force-pushed the remove-system-anonymoususer branch 4 times, most recently from 725d8d8 to 1fe0380 Compare November 17, 2020 09:38
Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalgrimaud pascalgrimaud merged commit c140433 into jhipster:main Nov 19, 2020
@ctamisier ctamisier deleted the remove-system-anonymoususer branch November 21, 2020 18:29
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants