-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to JDL annotation parsing #13044
Conversation
@MathieuAA this PR fixes item 1 from #12949. Can we merge? |
Number 2 takes a bit of time to do and test. I'm almost done, but it's tricky as it's a syntax change. |
@MathieuAA great thanks. |
Previous behaviour: the annotation added an option to both sides. New behaviour: an annotation on the source changes the destination, and one on the destination changes the source. Related to jhipster#12949
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have just a observation:
jpaDerivedIdentifier
should be deprecated soon.
A{b} to B{a} with jpaDerivedIdentifier
should be equivalent to:
A{b} to @Id B{a}
So I don't know how useful global options is.
Okay, when the option is removed, we can change the code later on then. |
@MathieuAA thanks. |
Fixes #12949
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.