Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to JDL annotation parsing #13044

Merged
merged 3 commits into from
Nov 29, 2020
Merged

Conversation

MathieuAA
Copy link
Member

Fixes #12949


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Nov 25, 2020

@MathieuAA this PR fixes item 1 from #12949. Can we merge?
Any update for item 2?

@MathieuAA
Copy link
Member Author

Number 2 takes a bit of time to do and test. I'm almost done, but it's tricky as it's a syntax change.

@mshima
Copy link
Member

mshima commented Nov 25, 2020

@MathieuAA great thanks.
See #12949 (comment).

Previous behaviour: the annotation added an option to both sides.
New behaviour: an annotation on the source changes the destination, and one
on the destination changes the source.

Related to jhipster#12949
@MathieuAA MathieuAA marked this pull request as ready for review November 29, 2020 19:47
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have just a observation:
jpaDerivedIdentifier should be deprecated soon.
A{b} to B{a} with jpaDerivedIdentifier
should be equivalent to:
A{b} to @Id B{a}

So I don't know how useful global options is.

@MathieuAA
Copy link
Member Author

Okay, when the option is removed, we can change the code later on then.

@mshima mshima merged commit 5e6a06c into jhipster:main Nov 29, 2020
@mshima
Copy link
Member

mshima commented Nov 29, 2020

@MathieuAA thanks.
Great work.

@MathieuAA MathieuAA deleted the fix-generated-data branch November 29, 2020 20:37
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jdl] Change jdl annotations.
3 participants