Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login redirect doesn't work in OAuth2 and Vue #13046

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Login redirect doesn't work in OAuth2 and Vue #13046

merged 3 commits into from
Nov 15, 2020

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Nov 15, 2020

Fix #13042


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert marked this pull request as ready for review November 15, 2020 14:21
@mraible
Copy link
Contributor

mraible commented Nov 15, 2020

This appears to work. There is a flash of a "forbidden" error and then it redirects to Keycloak to login.

Minor nit: Vue seems to bold all the top nav menu items, except for Home.

@qmonmert
Copy link
Contributor Author

@mraible I fix CSS bug in nav menu

@mraible
Copy link
Contributor

mraible commented Nov 15, 2020

It looks like there's a failing test.

@qmonmert qmonmert closed this Nov 15, 2020
@qmonmert qmonmert reopened this Nov 15, 2020
@qmonmert
Copy link
Contributor Author

@mraible it was a false positive, I restarted builds and it's ✅ 🙂

@mraible mraible merged commit 292a602 into jhipster:main Nov 15, 2020
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login redirect doesn't work in OAuth2 and Vue
3 participants