[angular] Use config similar to Angular strict mode #13065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://angular.io/guide/strict-mode fullTemplateTypeCheck is subset of strictTemplates so no need to specify this. Removed suppressImplicitAnyIndexErrors and added strictInputAccessModifiers and fixed errors after that, some comments: * in my Windows 10 metrics for system.load.average.1m, process.files.max and process.files.open is not coming from back end, but those are used in templates, so added those as optional to model * HMR support is improved lately (see angular/angular-cli#18788), maybe in Angular 11 manual module.hot fork can be removed at all
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://angular.io/guide/strict-mode
fullTemplateTypeCheckis subset ofstrictTemplatesso no need to specify this.Removed
suppressImplicitAnyIndexErrorsand addedstrictInputAccessModifiersand fixed errors after that, some comments:system.load.average.1m,process.files.maxandprocess.files.openare not coming from back end, but those are used in templates, so added those as optional to modelmodule.hotfork can be removed at allPlease make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.