Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub axios with sinon #13069

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

nonomoho
Copy link
Member

Fix #13066


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2020

CLA assistant check
All committers have signed the CLA.

@nonomoho nonomoho force-pushed the stub-axios-with-sinon branch 4 times, most recently from e5017c9 to 745762c Compare November 17, 2020 16:01
@pascalgrimaud
Copy link
Member

@nonomoho : can you update your git config, to use your email, associated to your GitHub account ? Because the CLA is already signed with this :)

@pascalgrimaud pascalgrimaud merged commit 38d2b0b into jhipster:main Nov 26, 2020
@nonomoho
Copy link
Member Author

Bounty claimed

@pascalgrimaud
Copy link
Member

With the link, it would be better @nonomoho :-D
But it's ok, I got the mail.

Approved ! Thanks for your contribution on Vue.js !

@nonomoho
Copy link
Member Author

Sorry, thank you Pascal, thank you JHipster !

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock axios with sinon
3 participants