Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix entity query to use unflattened DTO #13084

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

ruddell
Copy link
Member

@ruddell ruddell commented Nov 18, 2020

In the example:

entity Department
entity Location
relationship OneToOne {
  Department{location} to Location
}
dto * with mapstruct

DTOs are now unflattend (in #12947). Instead of calling for this.locationService.find(department.locationId), we should call this.locationService.find(department.location.id).

Fix #13080

Please make sure the below checklist is followed for Pull Requests.

@mshima mshima merged commit 6bc0b61 into jhipster:main Nov 18, 2020
@ruddell ruddell deleted the fix-entity-query branch November 18, 2020 21:28
@ruddell
Copy link
Member Author

ruddell commented Nov 18, 2020

Bounty claimed https://opencollective.com/generator-jhipster/expenses/28238

@pascalgrimaud
Copy link
Member

thanks for the fix !
@ruddell : approved

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If one-to-one relation value is selected then error in update form in Angular
4 participants