[angular] Clean up csrf.service #13107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As CsrfService is now used only in very specific case then we need to clean it up for the most use cases.
mshima
reviewed
Nov 20, 2020
| @@ -118,6 +118,7 @@ function cleanupOldFiles(generator) { | |||
| generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.ts`); | |||
| generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.html`); | |||
| generator.removeFile(`${ANGULAR_DIR}core/auth/user-route-access-service.ts`); | |||
| generator.removeFile(`${ANGULAR_DIR}core/auth/csrf.service.ts`); | |||
There was a problem hiding this comment.
You shouldn’t do this way, 2 options here:
- remove when not needed
- use
this.fs.delete(this.destinationPath(...));
Otherwise any change to the file will be overwritten every regeneration.
There was a problem hiding this comment.
OK, adding condition, will do PR shortly.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13098
As CsrfService is now used only in very specific case then we need to clean it up for most cases.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.