Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Fix some sonar issues #13113

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Conversation

kaidohallik
Copy link
Contributor

While reviewing #13110 found some Sonar code smells in Angular part which this PR fixes:

  • parameters with default values should be last
  • remove commented out code (as service worker is managed by Angular CLI after [angular] Switch to Angular CLI #10624 then this comment was outdated and could remove)

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit e60974d into jhipster:main Nov 21, 2020
@kaidohallik kaidohallik deleted the fix-sonar branch November 22, 2020 07:53
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants