Revert "[react] Fix default values in entity form" #13143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 27f6c01.
qmonmert
reviewed
Nov 25, 2020
| if (isNew) { | ||
| props.createEntity(cloneEntity); | ||
| props.createEntity(entity); |
There was a problem hiding this comment.
the ticket #12784 continue to work ?
There was a problem hiding this comment.
Yes it keeps working (Tried with oauth2 and keycloak, and tried before and after your fix).
Is there still a cloneEntity that I didn't remove ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify code, this part is no longer required.
Now, the use of normalized DTO ensures that a User is defined (linked to the entity) or not.
There is no "login" field in the handled Entity anymore that can be empty.
(The issue was only when DTO are used).
initial issue: #12784