Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Prepare folders in entity-client subgenerator for tests next to files they are testing #13160

Conversation

kaidohallik
Copy link
Contributor

This is the second PR according to #13125 (comment)

entity-management has already now too much files in one folder but after adding tests there, it's really badly readable, so splitting different components into different subfolders: list, detail, update, delete


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member

same here I'm trusting you, @kaidohallik so go ahead and merge it, if you feel confident :)

@kaidohallik
Copy link
Contributor Author

OK, @pascalgrimaud, I'm marking this PR as draft for now to think about how to proceed after #13125 (comment)

@kaidohallik kaidohallik marked this pull request as draft November 30, 2020 14:12
@kaidohallik kaidohallik marked this pull request as ready for review December 1, 2020 07:06
@kaidohallik
Copy link
Contributor Author

I'm merging this. If moving tests away from test folder then anyway whole spec folder will be deleted so no problem here.

@kaidohallik kaidohallik merged commit fb6789a into jhipster:main Dec 1, 2020
@kaidohallik kaidohallik deleted the prepare-entity-client-to-test-refactor branch December 1, 2020 07:09
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants