Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests next to the files they are testing in Angular #13171

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

kaidohallik
Copy link
Contributor

As per #13125 (comment) this PR moves tests next to the files they are testing.

This PR has 2 commits:

  • first moves tests next to the files they are testing
  • second polishes imports in tests, using ./ for files which are next to test

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

@kaidohallik Trusting you on this. Feel free to merge if you are confident
Just restarted 1 flaky test...

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaidohallik kaidohallik merged commit ce664a9 into jhipster:main Dec 1, 2020
@mshima
Copy link
Member

mshima commented Dec 1, 2020

The only problem I see it that we are removing the entire spec folder.
So if there are custom files there, they will be removed.
Not sure how to proceed here, but I think it's important to keep this in mind.

Solutions:

  • Remove file by file.
  • Make jhipster upgrade the only supported upgrade path for this use case.

@kaidohallik
Copy link
Contributor Author

I thought that they can revert their own files deletions. But you are right @mshima it's better to do clean up file by file. So I'm doing additional PR for cleaning test files file by file.

@kaidohallik kaidohallik deleted the angular-move-tests-to-src branch December 2, 2020 02:50
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants