Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdl] Don't set otherEntityField as 'id' by default. #13174

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 1, 2020

Not necessary and will conflict with composite id.

Related to #7112


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title Don't set otherEntityField as 'id' by default. [jdl] Don't set otherEntityField as 'id' by default. Dec 1, 2020
@mshima mshima requested a review from MathieuAA December 1, 2020 20:01
@mshima mshima merged commit 3bd944e into jhipster:main Dec 1, 2020
@mshima mshima deleted the skip_ci_jdl_other_field branch December 1, 2020 22:35
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants